Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include query parameters in sentry reports #440

Open
bloodearnest opened this issue Apr 10, 2019 · 0 comments
Open

Include query parameters in sentry reports #440

bloodearnest opened this issue Apr 10, 2019 · 0 comments

Comments

@bloodearnest
Copy link
Contributor

Currently, SQL queries are included as breadcrumbs, but with placeholders rather than with actual parameters, as this may leak senstive info (e.g. sessions or hashes). This limits their usefulness when debugging issues.

Instead, we should include the parameters in the sentry breadcrumb, but also have a blacklist of sensitive table names, that if present in the query, mean we fall back to the placeholder version of the query to avoid leaking.

We should probably have a default blacklist, e.g. 'user', 'session', as well as allow user to add their own blacklisted tables for their app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant