-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEY_GENERATE_REQUEST_ERROR - The initDataType parameter is empty (observed on Tizen 2017) #1259
Comments
Hi @peijkelhardt, I don't really now why it would appear in the The issue's source should be on There's actually a work-around for when the So maybe, when on Tizen 2017 and when !(error instanceof TypeError) By something like: (!(error instanceof TypeError) && (typeof InvalidStateError === "undefined" || !(error instanceof InvalidStateError))) (hard to reason about so maybe not the final code but it should not pass that condition if the error is an ? NOTE:
|
Hi @peaBerberian, I did a quick test by modifying the source code, but unfortunately, without success. You've mentioned both
When commenting the entire check: rx-player/src/compat/eme/generate_key_request.ts Lines 148 to 150 in e80e99a
This exception pops up:
|
OK, so it seems to consider the failed Can you directly replace the line:
By the work-around: return session.generateRequest(initDataType, patchedInit) ? |
Ah yes, sorry I mixed them up, we needed just to check for |
Hmm, those lines are identical. Can you please check again for the 'work-around' code? |
Oops yes sorry :D I meant the work-around of the following line: return session.generateRequest("cenc", patchedInit); To explain what we're doing: Basically generateRequest is the method which allows to generate a challenge, a necessary payload of data to make a license request. It has two parameters:
Here the Why the To just check if the work-around would work, I propose to directly force the |
This has a positive effect! The stream is able to play. When testting the setup I also added a small I've collected the logs (the
Also note that this behaviour occurs on a subset of our streams. We have different 3rd parties which serve the streams, and the ones which were not affected have the |
Issue observed on
Tizen 2017
, unclear which models might be affected as well.After updating the
RxPlayer
from3.29
to3.30
, some of our streams result in aEncryptedMediaError
. This happens with streams which useDASH
/Widevine
. When checking the behaviour of3.29
I noticed that these warnings are identical:Additionally, the
3.30
version throws this exception a bit later:Has something changed between these versions which might cause this behaviour?
The text was updated successfully, but these errors were encountered: