Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version tag binding input loses focus #4513

Closed
philippfromme opened this issue Sep 10, 2024 · 2 comments · Fixed by camunda/camunda-bpmn-js#377 or #4529
Closed

Version tag binding input loses focus #4513

philippfromme opened this issue Sep 10, 2024 · 2 comments · Fixed by camunda/camunda-bpmn-js#377 or #4529
Assignees
Labels
bug Something isn't working
Milestone

Comments

@philippfromme
Copy link
Contributor

Describe the bug

When typing in the _Version tag input of a business rule task, call activity or user task the input loses focus.

Camunda_Modeler_3PyQMsnuct

Steps to reproduce

  1. Focus Version tag input
  2. Start typing
  3. Focus lost

Expected behavior

Focus not lost.

Environment

  • Camunda Modeler Version: 5.27

Additional context

No response

@philippfromme philippfromme added the bug Something isn't working label Sep 10, 2024
@philippfromme philippfromme self-assigned this Sep 10, 2024
@nikku
Copy link
Member

nikku commented Sep 10, 2024

Related to this, two observations:

@jfriedenstab previously reported that validation for versionTag not being empty is not happening at all, which I can reproduce on Camunda Modeler v5.27.0:

image

At the same time "not supported" seems to validate both fields, the versionTag field, and the chooser, where I'd expect that the chooser only is the error, as this is where the user has to fix things:

image

@philippfromme
Copy link
Contributor Author

The reason for the focus loss is the use of withProps (cf. https://github.com/bpmn-io/bpmn-js-properties-panel/blob/main/src/provider/zeebe/properties/CalledDecisionProps.js#L56) and the fact that we effectively create a new component on every render. The Binding select uses withProps and has the same issue but it's not as obvious since there is no caret indicating focus.

To fix this issue we only want to create the component once (cf. bpmn-io/bpmn-js-properties-panel#1076) so that React doesn't replace it in the DOM on every render assuming it's a different component.

philippfromme added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue Sep 11, 2024
@philippfromme philippfromme added fixed upstream Requires integration of upstream change and removed ready Ready to be worked on labels Sep 11, 2024
@nikku nikku added this to the M81 milestone Sep 16, 2024
@bpmn-io-tasks bpmn-io-tasks bot closed this as completed Sep 18, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants