Build fix redo #353
Closed
Build fix redo #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, I noticed the windows error message said to try |
|
Is there anything wrong with me squashing this into a single commit once you have it working? |
|
Possibly a loss of operational knowledge in the steps one would take to fix these kinds of CI failures? |
|
I think I could squash them into 1 commit per operating system, with descriptions explaining how I figured out the problems and why I chose the fixes I did. |
|
Got everything from this cleaned up into #354 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleaner redo of the working build fixes from #352. I'd like to get it merged so I can rebase #351 onto it
This stops short of trying to fix the Mac library compatibility warnings, which I haven't figured out how to do yet.
Hopefully the Windows CI failure that was happening last night will go away when the CI runs today (it was a dependency download error that seemed outside of our control.)