Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Mac, preferences from replays seem to be applied persistently #456

Open
NQNStudios opened this issue Sep 25, 2024 · 2 comments
Open

On Mac, preferences from replays seem to be applied persistently #456

NQNStudios opened this issue Sep 25, 2024 · 2 comments
Labels
bug game Affects the game, as opposed to the editors mac Specific to Mac builds replay Affects the replay system

Comments

@NQNStudios
Copy link
Collaborator

I think I saw this happen, didn't confirm it, and forgot to write it down.

If it is the case, it'll be pretty annoying and worth fixing. We don't want replays to clobber our preferred settings.

It would make sense if Mac is doing it and Windows/Linux aren't, because Mac handles preferences differently.

@CelticMinstrel CelticMinstrel added bug mac Specific to Mac builds game Affects the game, as opposed to the editors unconfirmed replay Affects the replay system labels Sep 25, 2024
@NQNStudios
Copy link
Collaborator Author

I confirmed it, but going back over the code I don't see how it's happening.

@CelticMinstrel
Copy link
Member

I think the Cocoa preferences system syncs preferences in the background or something. Maybe replays shouldn't touch anything related to NSUserDefaults? I'm not really sure of that though. Looking at the current prefs code, it does clearly look like they shouldn't get saved. Maybe an NSUserDefaults automatically syncs when initialized? I'm just speculating here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug game Affects the game, as opposed to the editors mac Specific to Mac builds replay Affects the replay system
Projects
None yet
Development

No branches or pull requests

2 participants