Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow storing compilation stats in file #408

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

eps1lon
Copy link
Contributor

@eps1lon eps1lon commented Jul 31, 2023

Summary

Relanding #224 which was opened when v3 was default but merged when main became default. It was never released.

Test plan

  • in packages/TesterApp: yarn bundle:ios --stats normal --json stats.json:
    $ yarn bundle --stats normal --json stats.json
    ....
    webpack 5.75.0 compiled successfully in 26508 ms 
    Writing compiler stats
    Wrote compiler stats to /Users/sebastian.silbermann/repack/packages/TesterApp/stats.json
  • in packages/TesterApp: yarn bundle:ios --json stats.json with stats: { preset: 'normal' } in webpack.config.mjs
  • CI (needs maintainer approval)

@changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2023

🦋 Changeset detected

Latest commit: 725f3e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@callstack/repack Minor
testerapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reopening the PR @eps1lon and your contribution 🎉

@jbroma jbroma merged commit 3bcce76 into callstack:main Jul 31, 2023
4 checks passed
@eps1lon eps1lon deleted the feat/json-stats-main branch July 31, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants