Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckboxAndroid and CheckboxIOS use MaterialCommunityIcon instead of custom icon function from PaperProvider #4255

Open
jahirfiquitiva opened this issue Jan 4, 2024 · 2 comments
Labels

Comments

@jahirfiquitiva
Copy link

jahirfiquitiva commented Jan 4, 2024

Current behaviour

I have setup a custom icon in PaperProvider

import {FontAwesomeIcon} from '@fortawesome/react-native-fontawesome';
...
 <PaperProvider
	settings={{
		icon: props => <FontAwesomeIcon {...props} icon={props.name} />
	}}>
        // ...
  </PaperProvider>

But CheckboxAndroid and CheckboxIOS only use MaterialCommunityIcon instead of the icon function from the PaperProvider

Expected behaviour

CheckboxAndroid and CheckboxIOS should use Icon instead of MaterialCommunityIcon for the check icons.

How to reproduce?

https://snack.expo.dev/@jahirfiquitiva/greedy-yellow-turkish-delight

Preview

What have you tried so far?

Your Environment

software version
ios 17.0.1
android x
react-native 0.72.6
react-native-paper 5.11.6
node v18.18.2
npm or yarn 4.0.1
expo sdk x.x.x
@bhandanyan-nomad
Copy link

@lukewalczak

@artola
Copy link

artola commented Nov 11, 2024

@lukewalczak It seems that several components are not using the PaperProvider.settings.icon value. For example: RadioButtonIOS directly imports MaterialCommunityIcon and does not even try to use the value from the context.
Should not use this kind of block?

<SettingsConsumer>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants