Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has the "+ Add Variants" button made a comeback in version > 1.3.0? #80

Open
lianos opened this issue Oct 19, 2023 · 0 comments
Open

Has the "+ Add Variants" button made a comeback in version > 1.3.0? #80

lianos opened this issue Oct 19, 2023 · 0 comments

Comments

@lianos
Copy link

lianos commented Oct 19, 2023

Hi,

I'm not a javascript guru by any means, so I'm sorry for the naive question, but I've been working creating an wrapping this into an R/htmlwidget package that can be used from within R/shiny.

I've appreciated that the "+ Add Variants" button was removed by default, as noted in this issue in the 1.3.0 branch/release.

I'm not sure how actively this library is maintained, but I've noticed that there is a release/1.5.0 branch (as well as a 1.4.0), so I figured I might as well go from there, but it looks like the "+ Add Variants" button has made a come back.

It doesn't seem like there is an option to switch it off, but it seems like this might be something that could naturally be passed as some boolean flag in the options parameter of the createFeature constructor.

I'm curious if I'm missed something, or no?

Thanks!

@lianos lianos changed the title Has the "+ Add Variants" button made a comeback in version > 1.3.0 Has the "+ Add Variants" button made a comeback in version > 1.3.0? Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant