Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with bootstrap 4 #30

Open
Takkoona opened this issue Feb 27, 2018 · 1 comment
Open

Conflict with bootstrap 4 #30

Takkoona opened this issue Feb 27, 2018 · 1 comment

Comments

@Takkoona
Copy link

Hi,

I started my project with bootstrap 4 and didn't find feature-viewer until the late stage of development. The problem is my styling framework conflicts with feature-viewer's, which is because it's depended on bootstrap 3. The functional part remains unaffected but just the look of it is not so pleasant. I can use 'scoped style' to deal with the conflict but this technique is not supported by major browsers except Firefox 21+.

I saw some solutions that suggest using iframe or adding class name before css selector. It's not very necessary to use iframe in my case. Class name sounds like a way to go but cannot do too much my end. It would be great if the conflict can be solved.

And lastly I need to add an 'f' before the object id to select the element. It's been great using feature-viewer. It's highly programmable and I really enjoy it.

@MatSchaeff
Copy link
Contributor

Hello Takkoona,
Sorry for the late reply, do you still have this conflict of style?
I tried to reproduce it in this fiddle by importing bootstrap 4 css, but I cannot see the problem :
https://jsfiddle.net/3joge19v/1/

However I agree that bootstrap 3 is quite big for this viewer and shouldn't be required, or at least not all of it.
Thank you for your appreciation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants