Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In addition to addFeature(), we need isFeature(id) and removeFeature(id) #26

Open
BurkovBA opened this issue Dec 21, 2017 · 0 comments
Open

Comments

@BurkovBA
Copy link

Hi, thanks for this library (it's very nice)! We're using it in RNAcentral.org now and are pretty happy about it.

I have a feature request: sometimes, we want to add a feature only if it's not already present. Or sometimes it could be nice to remove and existing feature.

As you're using a factory function to construct your FeatureBrowser and make its features attribute private, it's impossible to access features directly without corresponding API methods.

Cheers!

BurkovBA added a commit to BurkovBA/feature-viewer that referenced this issue Dec 31, 2017
BurkovBA added a commit to BurkovBA/feature-viewer that referenced this issue Dec 31, 2017
BurkovBA added a commit to BurkovBA/feature-viewer that referenced this issue Dec 31, 2017
BurkovBA added a commit to BurkovBA/feature-viewer that referenced this issue Dec 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants