fix(devcontainer): configure git to install pre-commit #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
This PR does not seem to contain any modification to coverable code. |
|
Closing this PR for now |
|
Oops 😓 I didn't realize we hadn't merged #463 yet! |
|
@machikoyasuda #463 is merged now |
machikoyasuda
force-pushed
the
fix/473-pre-commit
branch
from
79180eb
to
daf87f3
Compare
|
Ready for review now @thekaveman Re-tested this on rebased branch with the latest from |
thekaveman
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #473
I followed what @lalver1 did for Benefits here cal-itp/benefits#2027 to fix this bug I got when I loaded the devcontainer on my macOS