Fix: unnecessary space on required form field label #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitespace around the tag contents was causing the issue
github-actions
bot
added
front-end
Coverage report
This PR does not seem to contain any modification to coverable code. |
thekaveman
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2033
djlint was re-formatting the HTML to put the
labelelement on separate lines. However, this caused there to be whitespace surrounding the text for the field label.This PR disables djlint for the form's
labelelements and removes the whitespace. See djlint docs on ignoring code.The built-in
spacelesstag from Django was close to what we needed except that it doesn't remove whitespace between tags and text.