Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: pin key requirements, fix extension syntax #1923

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

thekaveman
Copy link
Member

Closes #1895

ensure we are on the latest versions of mkdocs and mkdocs-material
ensure we get version updates for pinned docs requirements
this is now built-in to mkdocs-material directly
@thekaveman thekaveman self-assigned this Feb 29, 2024
@thekaveman thekaveman requested a review from a team as a code owner February 29, 2024 19:17
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@github-actions github-actions bot added documentation [auto] Improvements or additions to documentation actions Related to GitHub Actions workflows labels Feb 29, 2024
Copy link

Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix looks great! Locally, I see that using a timeline diagram works 🎉 Do we want to put back the Mermaid content in place of the image? And if so, I'm guessing a separate PR will do it?

@thekaveman thekaveman changed the title Docs: pin key requirements, fix extension sytanx Docs: pin key requirements, fix extension syntax Mar 1, 2024
@thekaveman
Copy link
Member Author

@indexing FYI ☝️

@thekaveman thekaveman merged commit d766e73 into dev Mar 1, 2024
13 checks passed
@thekaveman thekaveman deleted the docs/pin-requirements branch March 1, 2024 17:58
@indexing
Copy link
Member

indexing commented Mar 4, 2024

@angela-tran Yes! Let's add the Mermaid content in place of the image. I'll look for your guidance on the best way to reintroduce the code. Let me know how I can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions Related to GitHub Actions workflows documentation [auto] Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin mkdocs-material to the most recent version
3 participants