Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Question mark and color Login.gov sizing alignment #1554

Merged
merged 2 commits into from
Jul 22, 2023

Conversation

machikoyasuda
Copy link
Member

fixes #1553

This PR only deals with the color Login.gov icon (on Elig Index and Enrollment Success), and the question mark next to the Login.gov icon on Elig Index

The issues:

  • Sizing - ? should be 22x22, on both Desktop and Mobile
  • Sizing - the color Login.gov is a bit smaller than the white one, at 120x16.
  • There doesn't need to be the margin of 2px between the Login.gov button and the question mark (and any text).
image image

@machikoyasuda machikoyasuda requested a review from a team as a code owner July 21, 2023 17:21
@github-actions github-actions bot added front-end HTML/CSS/JavaScript and Django templates deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Jul 21, 2023
@machikoyasuda machikoyasuda self-assigned this Jul 21, 2023
@machikoyasuda machikoyasuda merged commit 17d2ecd into dev Jul 22, 2023
10 checks passed
@machikoyasuda machikoyasuda deleted the fix/1553-question-mark-login-gov-sizing-alignment branch July 22, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev front-end HTML/CSS/JavaScript and Django templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Login.gov/Question mark alignment and sizing
2 participants