Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Payment Processor API check workflow to use Back Office API #1814

Closed
2 of 3 tasks
thekaveman opened this issue Dec 7, 2023 · 0 comments · Fixed by #1889
Closed
2 of 3 tasks

Refactor Payment Processor API check workflow to use Back Office API #1814

thekaveman opened this issue Dec 7, 2023 · 0 comments · Fixed by #1889
Assignees
@angela-tran
Labels
actions Related to GitHub Actions workflows bug Something isn't working chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc.
Milestone
Back Office API E...

Comments

@thekaveman
Copy link
Member

thekaveman commented Dec 7, 2023 •
edited by angela-tran
Loading

Given what happened and the fix for #1810, it is surprising that the check-api workflow continues to succeed for QA. From what we understand about the certificates, this should not be the case.

In addition, now that the Prod cert has been rotated, we would expect that check to be failing as the cert has not been rotated in GitHub secrets.

This task is to entirely refactor these checks to use the Back Office API via our littlepay package.

Acceptance criteria

  • The QA check uses the Back Office API via littlepay
  • The Prod check uses the Back Office API via littlepay
  • All cert secrets are removed from this repository

Additional context

Depends on cal-itp/littlepay#10
@thekaveman thekaveman added the bug Something isn't working label Dec 7, 2023
@thekaveman thekaveman added this to the Back Office API Enrollment milestone Dec 8, 2023
@thekaveman thekaveman changed the title Investigate and update Payment Processor API check workflow Refactor Payment Processor API check workflow to use Back Office API Jan 9, 2024
@thekaveman thekaveman added chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc. actions Related to GitHub Actions workflows bug Something isn't working and removed bug Something isn't working labels Jan 9, 2024
@angela-tran angela-tran mentioned this issue Feb 13, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angela-tran angela-tran

Labels
actions Related to GitHub Actions workflows bug Something isn't working chore Chores and tasks for code cleanup, dev experience, admin/configuration settings, etc.
Projects
Digital Services
Status: Done
Milestone
Back Office API Enrollment
Development

Successfully merging a pull request may close this issue.

Refactor: use cal-itp/littlepay to check API access cal-itp/benefits
2 participants
@thekaveman @angela-tran