Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extremely nit-picky design things #1556

Closed
machikoyasuda opened this issue Jul 21, 2023 · 9 comments
Closed

Extremely nit-picky design things #1556

machikoyasuda opened this issue Jul 21, 2023 · 9 comments
Assignees

Comments

@machikoyasuda
Copy link
Member

machikoyasuda commented Jul 21, 2023

Doing a major front-end audit of dev-benefits.calitp.org/, comparing it with Figma, and making a list of discrepancies I notice.

I am starting a list of small fixes:

  1. Line-height is off on H1s, H2s: 1.5 is now 1.3
image image
@machikoyasuda machikoyasuda added this to the Veterans milestone Jul 21, 2023
@machikoyasuda machikoyasuda self-assigned this Jul 21, 2023
@machikoyasuda
Copy link
Member Author

machikoyasuda commented Jul 21, 2023

  1. Get started with Login.gov button width needs help on Tablet widths. It should not go into 2 lines if we can avoid it cleanly.
image image

@machikoyasuda
Copy link
Member Author

machikoyasuda commented Jul 21, 2023

  1. Login.gov modal - the distance from the top edge to the start of text should be 36px. This one's over 60px.
image image image

@machikoyasuda
Copy link
Member Author

  1. Help page - Change col-10 to col-md-8 col-10

@machikoyasuda
Copy link
Member Author

  1. Update the blue color Color Workshop on Cal-ITP Blue #1423

@machikoyasuda
Copy link
Member Author

  1. Mobile agency index/index page box now has rounded corners
image

@machikoyasuda
Copy link
Member Author

  1. Check the extra space here
image image

@machikoyasuda
Copy link
Member Author

  1. A stretch goal: To implement the focus ring Update focus ring  #1387

@machikoyasuda
Copy link
Member Author

  1. Index, Agency index - left-align is off
image image

No padding/margin-left necessary.

@thekaveman
Copy link
Member

Thanks for tracking all these @machikoyasuda! I turned each of your comments into a separate issue on the board, do we want to close this one in favor of the individual issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants