From d16630ecf6b563edc81530168aa1b048c000780e Mon Sep 17 00:00:00 2001 From: Angela Tran Date: Thu, 30 May 2024 20:48:44 +0000 Subject: [PATCH] fix(test): remove test that has been revealed to not be meaningful when the fixture was a Mock object, the test saw `uses_auth_verification` as a function, but now that the fixture is using an actual model object, the `@property` decorator obscures the function and makes it look like a `bool` type. the intent of the test was to ensure the function is called, but that is already covered by the `bool` being `True` which is already a part of other tests. --- tests/pytest/oauth/test_analytics.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/tests/pytest/oauth/test_analytics.py b/tests/pytest/oauth/test_analytics.py index 166d1fc11c..61d1afbfa8 100644 --- a/tests/pytest/oauth/test_analytics.py +++ b/tests/pytest/oauth/test_analytics.py @@ -3,15 +3,6 @@ from benefits.oauth.analytics import OAuthEvent -@pytest.mark.django_db -def test_OAuthEvent_checks_verifier_uses_auth_verification(app_request, mocked_session_verifier_uses_auth_verification): - mocked_verifier = mocked_session_verifier_uses_auth_verification(app_request) - - OAuthEvent(app_request, "event type") - - mocked_verifier.uses_auth_verification.assert_called_once - - @pytest.mark.django_db def test_OAuthEvent_verifier_client_name_when_uses_auth_verification( app_request, mocked_session_verifier_uses_auth_verification