From 5519328d8984f938d3a261f6a458a0b477e5fe45 Mon Sep 17 00:00:00 2001 From: Angela Tran Date: Mon, 19 Aug 2024 15:01:46 +0000 Subject: [PATCH] chore: rename field on TransitAgency to clarify it's the group of staff users, not the enrollment group --- benefits/core/migrations/0022_transitagency_group.py | 4 ++-- benefits/core/models.py | 2 +- tests/pytest/core/test_models.py | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/benefits/core/migrations/0022_transitagency_group.py b/benefits/core/migrations/0022_transitagency_group.py index 9bbecb5d1..a605b0928 100644 --- a/benefits/core/migrations/0022_transitagency_group.py +++ b/benefits/core/migrations/0022_transitagency_group.py @@ -1,4 +1,4 @@ -# Generated by Django 5.0.7 on 2024-08-16 16:08 +# Generated by Django 5.0.7 on 2024-08-19 14:53 import django.db.models.deletion from django.db import migrations, models @@ -14,7 +14,7 @@ class Migration(migrations.Migration): operations = [ migrations.AddField( model_name="transitagency", - name="group", + name="staff_group", field=models.OneToOneField( blank=True, default=None, diff --git a/benefits/core/models.py b/benefits/core/models.py index 100536084..3e71e2df9 100644 --- a/benefits/core/models.py +++ b/benefits/core/models.py @@ -353,7 +353,7 @@ class TransitAgency(models.Model): help_text="The name of the secret containing this agency's client_secret value used to access the TransitProcessor's API.", # noqa: E501 default="", ) - group = models.OneToOneField( + staff_group = models.OneToOneField( Group, on_delete=models.PROTECT, null=True, diff --git a/tests/pytest/core/test_models.py b/tests/pytest/core/test_models.py index b27f9ae78..bd81b5738 100644 --- a/tests/pytest/core/test_models.py +++ b/tests/pytest/core/test_models.py @@ -473,7 +473,7 @@ def test_TransitAgency_for_user_in_group(model_TransitAgency): agency_for_user = TransitAgency.by_id(model_TransitAgency.id) agency_for_user.pk = None - agency_for_user.group = group + agency_for_user.staff_group = group agency_for_user.save() user = User.objects.create_user(username="test_user", email="test_user@example.com", password="test", is_staff=True) @@ -488,7 +488,7 @@ def test_TransitAgency_for_user_not_in_group(model_TransitAgency): agency_for_user = TransitAgency.by_id(model_TransitAgency.id) agency_for_user.pk = None - agency_for_user.group = group + agency_for_user.staff_group = group agency_for_user.save() user = User.objects.create_user(username="test_user", email="test_user@example.com", password="test", is_staff=True)