From 220f49942cf5f620e32f2305b7b5af7d613621d9 Mon Sep 17 00:00:00 2001
From: Kegan Maher <kegan@compiler.la>
Date: Fri, 16 Aug 2024 00:12:11 +0000
Subject: [PATCH] refactor(templates): replace hardcoded routes with context

---
 benefits/core/templates/core/agency-index.html                | 3 +--
 benefits/core/templates/core/base.html                        | 4 ++--
 benefits/core/templates/core/includes/button--index.html      | 3 +--
 .../templates/core/includes/button--sign-out--login-gov.html  | 3 +--
 benefits/core/templates/core/includes/link--sign-out.html     | 3 +--
 benefits/core/templates/core/includes/nocookies.html          | 2 +-
 benefits/core/templates/core/includes/noscript.html           | 2 +-
 benefits/eligibility/templates/eligibility/confirm.html       | 2 +-
 benefits/eligibility/templates/eligibility/index.html         | 2 +-
 .../eligibility/templates/eligibility/start--calfresh.html    | 3 +--
 .../templates/eligibility/start--cst-agency-card.html         | 3 +--
 .../templates/eligibility/start--mst-courtesy-card.html       | 3 +--
 .../templates/eligibility/start--sbmtd-mobility-pass.html     | 3 +--
 benefits/eligibility/templates/eligibility/start--senior.html | 3 +--
 .../eligibility/templates/eligibility/start--veteran.html     | 3 +--
 benefits/eligibility/templates/eligibility/start.html         | 2 +-
 benefits/enrollment/templates/enrollment/index.html           | 3 +--
 benefits/enrollment/templates/enrollment/system_error.html    | 3 +--
 18 files changed, 19 insertions(+), 31 deletions(-)

diff --git a/benefits/core/templates/core/agency-index.html b/benefits/core/templates/core/agency-index.html
index 1f6680885..21182660f 100644
--- a/benefits/core/templates/core/agency-index.html
+++ b/benefits/core/templates/core/agency-index.html
@@ -6,6 +6,5 @@
 {% endblock title %}
 
 {% block call-to-action %}
-  {% url "eligibility:index" as url_continue %}
-  <a href="{{ url_continue }}" class="btn btn-lg btn-primary">{% translate "Get Started" %}</a>
+  <a href="{% url routes.ELIGIBILITY_INDEX %}" class="btn btn-lg btn-primary">{% translate "Get Started" %}</a>
 {% endblock call-to-action %}
diff --git a/benefits/core/templates/core/base.html b/benefits/core/templates/core/base.html
index 795fc4663..c27b2111e 100644
--- a/benefits/core/templates/core/base.html
+++ b/benefits/core/templates/core/base.html
@@ -106,7 +106,7 @@
       <div class="container d-none d-lg-block">
         <ul class="footer-links m-0 p-0 list-unstyled d-lg-flex gap-lg-4">
           <li>
-            <a class="footer-link m-0 p-0" href="{% url "core:help" %}">{% translate "Help" %}</a>
+            <a class="footer-link m-0 p-0" href="{% url routes.HELP %}">{% translate "Help" %}</a>
           </li>
           <li>
             <a class="footer-link m-0 p-0" href="https://cdt.ca.gov/privacy-policy/" target="_blank" rel="noopener noreferrer">{% translate "Privacy Policy" %}</a>
@@ -117,7 +117,7 @@
       <div class="d-block d-lg-none container">
         <ul class="col-12 footer-links ps-0 mb-0">
           <li>
-            <a class="footer-link" href="{% url "core:help" %}">{% translate "Help" %}</a>
+            <a class="footer-link" href="{% url routes.HELP %}">{% translate "Help" %}</a>
           </li>
         </ul>
       </div>
diff --git a/benefits/core/templates/core/includes/button--index.html b/benefits/core/templates/core/includes/button--index.html
index cbad5a856..204285249 100644
--- a/benefits/core/templates/core/includes/button--index.html
+++ b/benefits/core/templates/core/includes/button--index.html
@@ -1,6 +1,5 @@
 {% load i18n %}
 
-{% url "core:index" as href %}
 {% translate "Return home" as default_button_text %}
 
-<a href="{{ href }}" class="btn btn-lg btn-primary">{{ button_text | default:default_button_text }}</a>
+<a href="{% url routes.INDEX %}" class="btn btn-lg btn-primary">{{ button_text | default:default_button_text }}</a>
diff --git a/benefits/core/templates/core/includes/button--sign-out--login-gov.html b/benefits/core/templates/core/includes/button--sign-out--login-gov.html
index e3bb56340..2763f4718 100644
--- a/benefits/core/templates/core/includes/button--sign-out--login-gov.html
+++ b/benefits/core/templates/core/includes/button--sign-out--login-gov.html
@@ -1,8 +1,7 @@
 {% load i18n %}
 
 {% if authentication.logged_in %}
-  {% url "oauth:logout" as sign_out_url %}
-  <a href="{{ sign_out_url }}" class="login p-0 btn btn-lg" role="button">
+  <a href="{% url routes.OAUTH_LOGOUT %}" class="login p-0 btn btn-lg" role="button">
     <span class="fallback-text color-logo">Login.gov</span>
   </a>
 {% endif %}
diff --git a/benefits/core/templates/core/includes/link--sign-out.html b/benefits/core/templates/core/includes/link--sign-out.html
index 9694abfaa..08af25b67 100644
--- a/benefits/core/templates/core/includes/link--sign-out.html
+++ b/benefits/core/templates/core/includes/link--sign-out.html
@@ -1,10 +1,9 @@
 {% if authentication.logged_in %}
-  {% url "oauth:logout" as signout_url %}
   <div class="w-100 position-absolute">
     <div class="container">
       <div class="row nav-button-row">
         <div class="col-12 d-flex align-items-center justify-content-end">
-          <a class="signout-link" href="{{ signout_url }}">
+          <a class="signout-link" href="{% url routes.OAUTH_LOGOUT %}">
             {% block button_text %}
             {% endblock button_text %}
           </a>
diff --git a/benefits/core/templates/core/includes/nocookies.html b/benefits/core/templates/core/includes/nocookies.html
index 8df1484f0..a03ff4727 100644
--- a/benefits/core/templates/core/includes/nocookies.html
+++ b/benefits/core/templates/core/includes/nocookies.html
@@ -6,7 +6,7 @@
     <span class="navbar-brand">{% translate "Cookies are disabled" %}</span>
     <span class="navbar-text">
       {% translate "To function properly, this website requires a browser that supports cookies. Please enable cookies for this website and" %}
-      <a href="{% url "core:index" %}">{% translate "Return home" %}</a>.
+      <a href="{% url routes.INDEX %}">{% translate "Return home" %}</a>.
     </span>
   </div>
 {% endblock content %}
diff --git a/benefits/core/templates/core/includes/noscript.html b/benefits/core/templates/core/includes/noscript.html
index 69405e5f5..11c6fd414 100644
--- a/benefits/core/templates/core/includes/noscript.html
+++ b/benefits/core/templates/core/includes/noscript.html
@@ -6,7 +6,7 @@
     <span class="navbar-brand">{% translate "JavaScript is disabled" %}</span>
     <span class="navbar-text">
       {% translate "To function properly, this website requires a browser that supports JavaScript. Please enable JavaScript for this website and" %}
-      <a href="{% url "core:index" %}">{% translate "Return home" %}</a>.
+      <a href="{% url routes.INDEX %}">{% translate "Return home" %}</a>.
     </span>
   </div>
 {% endblock content %}
diff --git a/benefits/eligibility/templates/eligibility/confirm.html b/benefits/eligibility/templates/eligibility/confirm.html
index 31f617422..42b2743e7 100644
--- a/benefits/eligibility/templates/eligibility/confirm.html
+++ b/benefits/eligibility/templates/eligibility/confirm.html
@@ -5,7 +5,7 @@
 {% endblock page-title %}
 
 {% block nav-buttons %}
-  {% url "eligibility:start" as url_previous %}
+  {% url routes.ELIGIBILITY_START as url_previous %}
   {% include "core/includes/button--previous-page.html" with url=url_previous %}
 {% endblock nav-buttons %}
 
diff --git a/benefits/eligibility/templates/eligibility/index.html b/benefits/eligibility/templates/eligibility/index.html
index ad577a065..3468b1906 100644
--- a/benefits/eligibility/templates/eligibility/index.html
+++ b/benefits/eligibility/templates/eligibility/index.html
@@ -10,7 +10,7 @@
 {% endblock page-title %}
 
 {% block nav-buttons %}
-  {% url "core:index" as url %}
+  {% url routes.INDEX as url %}
   {% include "core/includes/button--previous-page.html" with url=url %}
 {% endblock nav-buttons %}
 
diff --git a/benefits/eligibility/templates/eligibility/start--calfresh.html b/benefits/eligibility/templates/eligibility/start--calfresh.html
index d968f9295..a9da5608f 100644
--- a/benefits/eligibility/templates/eligibility/start--calfresh.html
+++ b/benefits/eligibility/templates/eligibility/start--calfresh.html
@@ -18,9 +18,8 @@ <h1>{% translate "You selected a CalFresh Cardholder transit benefit." %}</h1>
 {% block call-to-action %}
   <div class="row d-flex justify-content-lg-end">
     <div class="col-lg-4 offset-2 offset-lg-0 col-sm-8 col-8 d-flex justify-content-lg-end justify-content-center">
-      {% url "oauth:login" as button_url %}
       {% translate "Get started with" as button_text %}
-      <a href="{{ button_url }}" class="btn btn-lg btn-primary login">
+      <a href="{% url routes.OAUTH_LOGIN %}" class="btn btn-lg btn-primary login">
         {{ button_text }} <span class="fallback-text white-logo">Login.gov</span>
       </a>
     </div>
diff --git a/benefits/eligibility/templates/eligibility/start--cst-agency-card.html b/benefits/eligibility/templates/eligibility/start--cst-agency-card.html
index 08962327f..1310be9b6 100644
--- a/benefits/eligibility/templates/eligibility/start--cst-agency-card.html
+++ b/benefits/eligibility/templates/eligibility/start--cst-agency-card.html
@@ -18,8 +18,7 @@ <h1>{% translate "You selected an Agency Card transit benefit." %}</h1>
 {% block call-to-action %}
   <div class="row d-flex justify-content-lg-end">
     <div class="col-lg-3 offset-2 offset-sm-2 offset-lg-0 col-sm-8 col-8">
-      {% url "eligibility:confirm" as button_url %}
-      <a href="{{ button_url }}" class="btn btn-lg btn-primary" role="button">{% translate "Continue" %}</a>
+      <a href="{% url routes.ELIGIBILITY_CONFIRM %}" class="btn btn-lg btn-primary" role="button">{% translate "Continue" %}</a>
     </div>
   </div>
 {% endblock call-to-action %}
diff --git a/benefits/eligibility/templates/eligibility/start--mst-courtesy-card.html b/benefits/eligibility/templates/eligibility/start--mst-courtesy-card.html
index e21635c94..1cf94ef9e 100644
--- a/benefits/eligibility/templates/eligibility/start--mst-courtesy-card.html
+++ b/benefits/eligibility/templates/eligibility/start--mst-courtesy-card.html
@@ -18,8 +18,7 @@ <h1>{% translate "You selected a Courtesy Card transit benefit." %}</h1>
 {% block call-to-action %}
   <div class="row d-flex justify-content-lg-end">
     <div class="col-lg-3 offset-2 offset-sm-2 offset-lg-0 col-sm-8 col-8">
-      {% url "eligibility:confirm" as button_url %}
-      <a href="{{ button_url }}" class="btn btn-lg btn-primary" role="button">{% translate "Continue" %}</a>
+      <a href="{% url routes.ELIGIBILITY_CONFIRM %}" class="btn btn-lg btn-primary" role="button">{% translate "Continue" %}</a>
     </div>
   </div>
 {% endblock call-to-action %}
diff --git a/benefits/eligibility/templates/eligibility/start--sbmtd-mobility-pass.html b/benefits/eligibility/templates/eligibility/start--sbmtd-mobility-pass.html
index f2951d2af..0fe01b9e0 100644
--- a/benefits/eligibility/templates/eligibility/start--sbmtd-mobility-pass.html
+++ b/benefits/eligibility/templates/eligibility/start--sbmtd-mobility-pass.html
@@ -18,8 +18,7 @@ <h1>{% translate "You selected a Reduced Fare Mobility ID transit benefit." %}</
 {% block call-to-action %}
     <div class="row d-flex justify-content-lg-end">
         <div class="col-lg-3 offset-2 offset-sm-2 offset-lg-0 col-sm-8 col-8">
-            {% url "eligibility:confirm" as button_url %}
-            <a href="{{ button_url }}" class="btn btn-lg btn-primary" role="button">{% translate "Continue" %}</a>
+            <a href="{% url routes.ELIGIBILITY_CONFIRM %}" class="btn btn-lg btn-primary" role="button">{% translate "Continue" %}</a>
         </div>
     </div>
 {% endblock call-to-action %}
diff --git a/benefits/eligibility/templates/eligibility/start--senior.html b/benefits/eligibility/templates/eligibility/start--senior.html
index a1e2ce765..31ad0b443 100644
--- a/benefits/eligibility/templates/eligibility/start--senior.html
+++ b/benefits/eligibility/templates/eligibility/start--senior.html
@@ -18,9 +18,8 @@ <h1>{% translate "You selected an Older Adult transit benefit." %}</h1>
 {% block call-to-action %}
   <div class="row d-flex justify-content-lg-end">
     <div class="col-lg-4 offset-2 offset-lg-0 col-sm-8 col-8 d-flex justify-content-lg-end justify-content-center">
-      {% url "oauth:login" as button_url %}
       {% translate "Get started with" as button_text %}
-      <a href="{{ button_url }}" class="btn btn-lg btn-primary login">
+      <a href="{% url routes.OAUTH_LOGIN %}" class="btn btn-lg btn-primary login">
         {{ button_text }} <span class="fallback-text white-logo">Login.gov</span>
       </a>
     </div>
diff --git a/benefits/eligibility/templates/eligibility/start--veteran.html b/benefits/eligibility/templates/eligibility/start--veteran.html
index f398aa4de..06233a9d0 100644
--- a/benefits/eligibility/templates/eligibility/start--veteran.html
+++ b/benefits/eligibility/templates/eligibility/start--veteran.html
@@ -18,9 +18,8 @@ <h1>{% translate "You selected a Veteran transit benefit." %}</h1>
 {% block call-to-action %}
   <div class="row d-flex justify-content-lg-end">
     <div class="col-lg-4 offset-2 offset-lg-0 col-sm-8 col-8 d-flex justify-content-lg-end justify-content-center">
-      {% url "oauth:login" as button_url %}
       {% translate "Get started with" as button_text %}
-      <a href="{{ button_url }}" class="btn btn-lg btn-primary login">
+      <a href="{% url routes.OAUTH_LOGIN %}" class="btn btn-lg btn-primary login">
         {{ button_text }} <span class="fallback-text white-logo">Login.gov</span>
       </a>
     </div>
diff --git a/benefits/eligibility/templates/eligibility/start.html b/benefits/eligibility/templates/eligibility/start.html
index e7aa4b347..44dfe02d0 100644
--- a/benefits/eligibility/templates/eligibility/start.html
+++ b/benefits/eligibility/templates/eligibility/start.html
@@ -6,7 +6,7 @@
 {% endblock classes %}
 
 {% block nav-buttons %}
-  {% url "eligibility:index" as url %}
+  {% url routes.ELIGIBILITY_INDEX as url %}
   {% include "core/includes/button--previous-page.html" with url=url %}
 {% endblock nav-buttons %}
 
diff --git a/benefits/enrollment/templates/enrollment/index.html b/benefits/enrollment/templates/enrollment/index.html
index f1983d5bb..50488da05 100644
--- a/benefits/enrollment/templates/enrollment/index.html
+++ b/benefits/enrollment/templates/enrollment/index.html
@@ -33,14 +33,13 @@ <h1 class="pb-lg-8 pb-4">
     This Javascript code is partially generated by this template and so it must
     come before the forms, which are rendered at just before the {% endblock inner-content %}
   {% endcomment %}
-  {% url "enrollment:token" as access_token_url %}
   {% translate "Please wait..." as loading_text %}
   <script nonce="{{ request.csp_nonce }}">
       var startedEvent = "started payment connection", closedEvent = "closed payment connection";
 
       $.ajax({ dataType: "script", attrs: { nonce: "{{ request.csp_nonce }}"}, url: "{{ card_tokenize_url }}" })
           .done(function() {
-          $.get("{{ access_token_url }}", function(data) {
+          $.get("{% url routes.ENROLLMENT_TOKEN %}", function(data) {
               if (data.redirect) {
                 // https://stackoverflow.com/a/42469170
                 // use 'assign' because 'replace' was giving strange Back button behavior
diff --git a/benefits/enrollment/templates/enrollment/system_error.html b/benefits/enrollment/templates/enrollment/system_error.html
index 3324701cd..42382a631 100644
--- a/benefits/enrollment/templates/enrollment/system_error.html
+++ b/benefits/enrollment/templates/enrollment/system_error.html
@@ -31,9 +31,8 @@ <h1 class="h2 text-center">
     <div class="row pt-8 justify-content-center">
       <div class="col-lg-3 col-8">
         {% if authentication and authentication.sign_out_link_template %}
-          {% url "oauth:logout" as sign_out_url %}
           {% translate "Sign out of" as button_text %}
-          <a href="{{ sign_out_url }}" class="btn btn-lg btn-primary login">
+          <a href="{% url routes.OAUTH_LOGOUT %}" class="btn btn-lg btn-primary login">
             {{ button_text }} <span class="fallback-text white-logo">Login.gov</span>
           </a>
         {% else %}