For notls #12
Merged
For notls #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanterno
reviewed
Oct 3, 2023
| ProxyAddr="http://localhost:$(( 2001 + node * 2))" | ||
| echo -n "Adding proxy for node $(( node + 1)): " | ||
| for node in $(seq 0 3); do | ||
| NodeAddr="grpc://localhost:$((2000 + node * 2))" |
There was a problem hiding this comment.
From our test yesterday, it seems that the node address is expected without the protocol (ie. grpc).
There was a problem hiding this comment.
Which test? With the changes in dela#fix-notls, the standard protocol is grpcs. If you want something else, it needs to be specified.
There was a problem hiding this comment.
But when we used this script together yesterday, it generated a 404 on the backend.
|
there are some required changes in the Dockerfile/docker-compose.yml as well, I'll add them after we merged this one so LGTM |
PascalinDe
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--noTLSReview request: start with c4dt/dela#3