Run the nightly CI job when pulley files are touched in a PR
#9391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After bytecodealliance#9251, we will check that Pulley builds with rustc's experimental tail calls feature enabled in the nightly CI job. So if we touch any pulley source files in a PR, we should also run that job in the PR's CI.
alexcrichton
reviewed
Oct 7, 2024
.github/workflows/main.yml
Outdated
| @@ -1027,7 +1033,7 @@ jobs: | |||
| - "wasmtime-environ" | |||
| - "pulley-interpreter --all-features" | |||
| needs: determine | |||
| if: needs.determine.outputs.run-full && github.repository == 'bytecodealliance/wasmtime' | |||
| if: (needs.determine.outputs.run-full || needs.determine.outputs.test-miri) && github.repository == 'bytecodealliance/wasmtime' | |||
There was a problem hiding this comment.
This is ok to change to just test-miri since run-full always implies that test-miri is true above (most of the other jobs don't check both, they only check the one)
alexcrichton
approved these changes
Oct 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #9251, we will check that Pulley builds with rustc's experimental tail calls feature enabled in the nightly CI job. So if we touch any pulley source files in a PR, we should also run that job in the PR's CI.