Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: failed to rebuild spidermonkey benchmark #231

Open
abrown opened this issue Mar 20, 2023 · 2 comments
Open

benchmark: failed to rebuild spidermonkey benchmark #231

abrown opened this issue Mar 20, 2023 · 2 comments

Comments

@abrown
Copy link
Collaborator

abrown commented Mar 20, 2023

The "rebuild benchmarks" CI workflow found an issue rebuilding the SpiderMonkey benchmark: https://github.com/bytecodealliance/sightglass/actions/runs/4453084060/jobs/7821309649#step:4:5101. This CI workflow only rebuilds a subset of the benchmarks each CI run (for time's sake) to check that they can be rebuilt deterministically, so the failure will only reappear occasionally. cc: @cfallin

@cfallin
Copy link
Member

cfallin commented Mar 21, 2023

Hmm -- I took a look at this and was able to reproduce locally. I'm not sure where the mach bootstrap error is coming from though. The version of SpiderMonkey we have pinned is fairly outdated so it's possible that the toolchain it's trying to download no longer exists, and an update to latest SpiderMonkey would fix this. (I don't have the bandwidth to do this at the moment, but we can leave this open to track...)

@william-stacken
Copy link

william-stacken commented Mar 22, 2023

I was able to get around this by editing the Spidermonkey Dockerfile to clone the fork https://github.com/fastly/spidermonkey-wasi-embedding instead of https://github.com/tschneidereit/spidermonkey-wasi-embedding.
But for some reason the runtime.cpp gets stuck somewhere inside JS_Init() when I attempt to run the benchmark.

EDIT: I found out that the reason the benchmark got stuck was because for some reason __wasm_call_ctors never got invoked in the _start function. When I manually called it in the main function of runtime.cpp the benchmark ran successfully.

EDIT 2: Nevermid me, I had inserted a call to __wasm_call_ctors at a different place in the code, which I think causes wasi sdk version 14 to think that the different place was the entrypoint and not the main function. Using the fork I mentioned works for me at least.

abrown added a commit to abrown/sightglass that referenced this issue Jun 14, 2023
The `spidermonkey` build failures are already captured in bytecodealliance#231.
abrown added a commit to abrown/sightglass that referenced this issue Jun 14, 2023
The `spidermonkey` build failures are already captured in bytecodealliance#231.
abrown added a commit that referenced this issue Jun 14, 2023
The `spidermonkey` build failures are already captured in #231.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants