Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ancestry] Use assembly when choosing which model to use #422

Open
akotlar opened this issue Mar 8, 2024 · 0 comments
Open

[ancestry] Use assembly when choosing which model to use #422

akotlar opened this issue Mar 8, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@akotlar
Copy link
Collaborator

akotlar commented Mar 8, 2024

Background:

A concise description of why we're pursuing this task.

Currently we assume all ancestry requests are for hg38. As we don't have a liftover step, preferring to natively process hg19 vcf's, we need to carry the assembly in the ancestry submission job request, so that the appropriate model can be loaded.

In #421 we thread through AncestryData.

In this ticket we need to update ancestry/inference.py to load the appropriate model based on the AncestryData.assembly

Completion Criteria:

What is the goal, and how do we know this task is accomplished?

In inference.py AncestryData.assembly is used to choose the model to load

Implementation Summary

Give enough technical detail for a teammate to understand the proposed solution.

AncestryJobData needs to now expect an assembly property (string valued). This property then needs to be threaded through to the ancestry inference procedure, which currently hardcodes an hg38 expectation

@akotlar akotlar added this to the Sprint 9 milestone Mar 8, 2024
@akotlar akotlar self-assigned this Mar 8, 2024
akotlar added a commit that referenced this issue Mar 12, 2024
…le (#427)

* Dynamically load model based on the assembly passed in the job request
* Cache up to 2 models to improve startup time

Stacked on
159bdcf

The commit for this PR:
1e64548

Also addresses #422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant