You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A concise description of why we're pursuing this task.
Currently we assume all ancestry requests are for hg38. As we don't have a liftover step, preferring to natively process hg19 vcf's, we need to carry the assembly in the ancestry submission job request, so that the appropriate model can be loaded.
In this ticket we need to update ancestry/inference.py to load the appropriate model based on the AncestryData.assembly
Completion Criteria:
What is the goal, and how do we know this task is accomplished?
In inference.py AncestryData.assembly is used to choose the model to load
Implementation Summary
Give enough technical detail for a teammate to understand the proposed solution.
AncestryJobData needs to now expect an assembly property (string valued). This property then needs to be threaded through to the ancestry inference procedure, which currently hardcodes an hg38 expectation
The text was updated successfully, but these errors were encountered:
…le (#427)
* Dynamically load model based on the assembly passed in the job request
* Cache up to 2 models to improve startup time
Stacked on
159bdcf
The commit for this PR:
1e64548
Also addresses #422
Background:
A concise description of why we're pursuing this task.
Currently we assume all ancestry requests are for hg38. As we don't have a liftover step, preferring to natively process hg19 vcf's, we need to carry the assembly in the ancestry submission job request, so that the appropriate model can be loaded.
In #421 we thread through AncestryData.
In this ticket we need to update ancestry/inference.py to load the appropriate model based on the AncestryData.assembly
Completion Criteria:
What is the goal, and how do we know this task is accomplished?
In inference.py AncestryData.assembly is used to choose the model to load
Implementation Summary
Give enough technical detail for a teammate to understand the proposed solution.
AncestryJobData needs to now expect an assembly property (string valued). This property then needs to be threaded through to the ancestry inference procedure, which currently hardcodes an hg38 expectation
The text was updated successfully, but these errors were encountered: