Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callout at top of editor if subscriber count exceeds plan limits #3467

Open
benborgers opened this issue Sep 18, 2024 · 2 comments
Open
Labels
Module: Core Application Type: Ergonomics Improvements to the existing user experience.

Comments

@benborgers
Copy link
Collaborator

No description provided.

@benborgers benborgers added Type: Ergonomics Improvements to the existing user experience. Module: Core Application labels Sep 18, 2024
@jmduke
Copy link
Member

jmduke commented Sep 18, 2024

I remove this in https://github.com/buttondown/monorepo/commit/f39c9727f0de1cf9b08179a0b92a399a1e35ae3e#diff-e6ec570c49d15d43173d1f0b516ae521b1262c8eb68306ebb0ad40e37654557a because it was a surprisingly large performance bottleneck. I think we can bring it back by just exposing a new API route (not unlike needs_billing_information, which I deleted like a fool) and calling that in the generateCallouts flow.

@jmduke
Copy link
Member

jmduke commented Sep 18, 2024

"Why is it a surprisingly large performance bottleneck" → because we have to count every unique subscriber for the account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Core Application Type: Ergonomics Improvements to the existing user experience.
Projects
Status: Not started
Development

No branches or pull requests

2 participants