Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only pass appropriate actions to cards, depending on mode #18

Open
bantic opened this issue Oct 15, 2015 · 0 comments
Open

only pass appropriate actions to cards, depending on mode #18

bantic opened this issue Oct 15, 2015 · 0 comments

Comments

@bantic
Copy link
Contributor

bantic commented Oct 15, 2015

component cards currently get the full set of component actions (editCard, saveCard, etc), but some of the actions are meaningless depending on the card's current mode. If the card is in edit mode, the editCard action is meaningless, for example.

An improvement would be to only pass the appropriate actions and/or give a meaningful error message if the action does not make sense (calling editCard when card is in edit mode, e.g.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant