RFC for pack detect #308
Merged
RFC for pack detect #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maintainers, As you review this RFC please queue up issues to be created using the following commands: Issues(none) |
2 tasks
natalieparellano
added
type/rfc
scope/team
There was a problem hiding this comment.
Thanks for kicking this off @rashadism! I would love to see this happen :)
|
Thank you @natalieparellano , will update on the stuff you pointed out. |
|
I opened a corresponding draft PR . @natalieparellano can u have a look |
|
@jjbustamante is going to steward this one :) |
nice, looking forward to it (: |
dmikusa
reviewed
May 13, 2024
dmikusa
reviewed
May 13, 2024
dmikusa
reviewed
May 13, 2024
dmikusa
reviewed
May 13, 2024
dmikusa
reviewed
May 13, 2024
|
I think this one might be ready for another round of reviews. |
1 task
natalieparellano
approved these changes
Jul 30, 2024
natalieparellano
added
status/ready-for-review
and removed
status/steward-assigned
labels
|
Maintainers, please review! I'll move this one to "voting" on Thursday. |
dmikusa
approved these changes
Jul 30, 2024
Signed-off-by: Rashad Sirajudeen <[email protected]>
Co-authored-by: Daniel Mikusa <[email protected]> Signed-off-by: Rashad Sirajudeen <[email protected]>
Signed-off-by: Rashad Sirajudeen <[email protected]>
Signed-off-by: Rashad Sirajudeen <[email protected]>
|
@rashadism can I get your acceptance on the DCO? I can mark it passed and merge if you'll reply back with a 👍 |
jjbustamante
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A basic implementation on
pack detect.Looking forward on getting feedback and improving on this and coming up with the best version of this, and implenenting this.