Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default config doesn't work when there's a wait: true #34

Open
jamietanna opened this issue Oct 23, 2024 · 0 comments
Open

default config doesn't work when there's a wait: true #34

jamietanna opened this issue Oct 23, 2024 · 0 comments

Comments

@jamietanna
Copy link

When using the new default configuration released as part of #20 / #29, it appears that this does not work in conjunction with the wait: true

For the following Buildkite configuration:

steps:
  - label: "Triggering pipelines"
    plugins:
      monorepo-diff#v1.1.0:
        diff: ".buildkite/diff ${BUILDKITE_COMMIT}"
        wait: true
        watch:
          - path: "renovate.json"
            config:
              label: "Verify Renovate configuration"
              command: "renovate-config-validator"
              agents:
                # ...

          # ... otherwise, fall back to the default pipeline
          - default:
              config:
                label: ":pipeline: Upload default Pipeline"
                command: "buildkite-agent pipeline upload .buildkite/default-pipeline.yml"

This then fails to run:

$ /buildkite-agent/plugins/.../github-com-buildkite-plugins-monorepo-diff-buildkite-plugin-v1-1-0/hooks/command
INFO[0000] --- running monorepo-diff-buildkite-plugin 1.1.0
INFO[2024-10-23T08:45:46Z] Running diff command: .buildkite/diff d5e161b1e7c95f41861f0c84b73d5097175a5328
Generated Pipeline:
steps:
- {}
- wait: null
FATA[2024-10-23T08:45:48Z] +++ failed to upload pipeline: command `buildkite-agent` failed: exit status 1
🚨 Error: The command exited with status 1
user command error: The plugin monorepo-diff command hook exited with status 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant