Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for "default" config to run if no path match #23

Open
fivetran-joseolmo opened this issue Aug 6, 2024 · 2 comments
Open

Allow for "default" config to run if no path match #23

fivetran-joseolmo opened this issue Aug 6, 2024 · 2 comments

Comments

@fivetran-joseolmo
Copy link

fivetran-joseolmo commented Aug 6, 2024

Hi!
Would it be possible to have a “default” build for when no path matched the watched folders?
So, basically, we’d like to have a pipeline definition like this:

steps:
  - key: tests-pipeline
    label: ":pipeline:"
    plugins:
      - monorepo-diff#v1.0.1:
          watch:
            - path: folder_a/**
              config:
                command: buildkite-agent pipeline upload a_tests.yml
            - path: folder_b/**
              config:
                command: buildkite-agent pipeline upload b_tests.yml
            - default:
              config:
                command: buildkite-agent pipeline upload other_tests.yml

We want other_tests to run if the changes happen on any folder other than folder_a or folder_b
Also, like the current functionality on the plugin, if change happens on all three "paths" we would like all three pipelines to run.
We could accomplish this with glob exclude patterns but they do not seem to work at the moment according to this issue: adikari#95

@jamietanna
Copy link

This would probably cover the suggestion raised in #20 (comment) (aka else) quite nicely

@tomowatt
Copy link

Hey @fivetran-joseolmo
With the release of v1.1.0 which includes the support for a "default" config, wanted to check if this resolves this issue and the request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants