Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction multi-signature support #53

Open
3Nigma opened this issue Apr 10, 2022 · 0 comments
Open

Add transaction multi-signature support #53

3Nigma opened this issue Apr 10, 2022 · 0 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@3Nigma
Copy link
Contributor

3Nigma commented Apr 10, 2022

ApiSession.execute should allow transactions to be signed by multiple Signers before being dispatched to the network.

This only will need to be carried out for Transactions through their Transaction.signWithSigner(signer) method since Querys don't require or support this multi-signature support.

This also means that we will only support HIP-338 compatible Signers for this feature.

We need to provide the ApiSession instance with a default list of Signers so that all Transactions dispatched through that instance's ApiSession.execute are implicitly signed through those Signers before dispatching.

In case of LiveContracts we also need to provide meta-arguments to allow signer overrides or ad-hoc usage that bypass the ApiSession default lists.

Let's discuss the specifics of this feature on this thread.

@3Nigma 3Nigma added help wanted Extra attention is needed question Further information is requested labels Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant