Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate polling intervals for sockets #140

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Separate polling intervals for sockets #140

merged 3 commits into from
Sep 24, 2024

Conversation

roxblnfk
Copy link
Member

What was changed

Separate polling intervals for sockets have been added using the methods socket_select() and socket_accept().

Why?

To avoid errors on socket resource due to excessively frequent polling of the state.

Checklist

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 22.59%. Comparing base (17f299e) to head (6016c18).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/Sender/Console/Renderer/Sentry/Exceptions.php 0.00% 12 Missing ⚠️
src/Socket/Server.php 0.00% 9 Missing ⚠️
src/Socket/Client.php 0.00% 6 Missing ⚠️
src/Application.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #140      +/-   ##
============================================
- Coverage     22.73%   22.59%   -0.14%     
+ Complexity     1334     1333       -1     
============================================
  Files           157      157              
  Lines          4170     4182      +12     
============================================
- Hits            948      945       -3     
- Misses         3222     3237      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the tests Changes in the tests label Sep 23, 2024
@roxblnfk roxblnfk mentioned this pull request Sep 24, 2024
@roxblnfk roxblnfk merged commit 00c8b8f into master Sep 24, 2024
23 of 27 checks passed
@roxblnfk roxblnfk deleted the maintenance branch September 24, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Changes in the tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High cpu usage
1 participant