Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unreleased version of protoc for custom check plugins #156

Closed
wants to merge 1 commit into from
Closed

Use unreleased version of protoc for custom check plugins #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions internal/gen/proto/go/org/foo/v1/foo.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions make/go/dep_protoc_gen_go.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@ $(call _assert_var,CACHE_VERSIONS)
$(call _assert_var,CACHE_BIN)

# Settable
# https://github.com/protocolbuffers/protobuf-go/releases 20240906 checked 20240916
PROTOC_GEN_GO_VERSION ?= v1.34.3-0.20240906163944-03df6c145d96
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit 03df6c1 is the latest commit on master, which includes commit 94ecbc2 from Aug 16, 2024.

I presume we don't want to be this far ahead? No strong opinion either way, we just need this commit to be at or ahead of whatever is in bufbuild/buf.

# https://github.com/protocolbuffers/protobuf-go/releases 20240816 checked 20240904
# TODO: Change back to released version once bug is fixed
PROTOC_GEN_GO_VERSION ?= 94ecbc26168965a670a0f7cf86f658131c790a9c


GO_GET_PKGS := $(GO_GET_PKGS) \
google.golang.org/protobuf/proto@$(PROTOC_GEN_GO_VERSION)
Expand Down