Use unreleased version of protoc for custom check plugins #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfridman
reviewed
Sep 23, 2024
| @@ -7,8 +7,10 @@ $(call _assert_var,CACHE_VERSIONS) | |||
| $(call _assert_var,CACHE_BIN) | |||
|
|
|||
| # Settable | |||
| # https://github.com/protocolbuffers/protobuf-go/releases 20240906 checked 20240916 | |||
| PROTOC_GEN_GO_VERSION ?= v1.34.3-0.20240906163944-03df6c145d96 | |||
There was a problem hiding this comment.
Commit 03df6c1 is the latest commit on master, which includes commit 94ecbc2 from Aug 16, 2024.
I presume we don't want to be this far ahead? No strong opinion either way, we just need this commit to be at or ahead of whatever is in bufbuild/buf.
mfridman
approved these changes
Sep 23, 2024
|
Closing this, since we're all good, going to sync up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change https://github.com/protocolbuffers/protobuf-go/blob/94ecbc26168965a670a0f7cf86f658131c790a9c/reflect/protodesc/desc_init.go#L218-L220 was pulled in
to support custom lint/breaking plugins, so updating
makegoto reflect this change frombufbuild/buf.