Skip to content

Commit

Permalink
Update go and golangci-lint
Browse files Browse the repository at this point in the history
  • Loading branch information
smaye81 committed Aug 30, 2024
1 parent 9842b33 commit 565239f
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ linters:
- cyclop # covered by gocyclo
- depguard # newer versions require explicit config to depend on anything outside of the Go stdlib
- execinquery # deprecated by author
- exportloopref # deprecated in golangci v1.60.2
- funlen # rely on code review to limit function length
- gocognit # dubious "cognitive overhead" quantification
- gofumpt # prefer standard gofmt
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/bufbuild/makego

go 1.21
go 1.22

require (
github.com/stretchr/testify v1.9.0
Expand Down
4 changes: 2 additions & 2 deletions make/go/dep_golangci_lint.mk
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ $(call _assert_var,CACHE_BIN)
GOLANGCI_LINT_GO_VERSION := $(shell go mod edit -json | jq -r .Go | cut -d'.' -f1-2)

# Settable
# https://github.com/golangci/golangci-lint/releases 20240813 checked 20240815
# https://github.com/golangci/golangci-lint/releases 20240822 checked 20240830
# Contrast golangci-lint configuration with the one in https://github.com/connectrpc/connect-go/blob/main/.golangci.yml when upgrading
GOLANGCI_LINT_VERSION ?= v1.60.1
GOLANGCI_LINT_VERSION ?= v1.60.3

GOLANGCI_LINT := $(CACHE_VERSIONS)/golangci-lint/$(GOLANGCI_LINT_VERSION)-go$(GOLANGCI_LINT_GO_VERSION)
$(GOLANGCI_LINT):
Expand Down

0 comments on commit 565239f

Please sign in to comment.