Replies: 6 comments 2 replies
-
|
Thanks a million for intiating this work 😍 |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for gathering those. See buddypress/buddypress#232 |
Beta Was this translation helpful? Give feedback.
-
|
@imath, @renatonascalves & @vapvarun Added footnote to the |
Beta Was this translation helpful? Give feedback.
-
|
@dcavins , @imath, @renatonascalves & @vapvarun Added footnote to the |
Beta Was this translation helpful? Give feedback.
-
|
Added |
Beta Was this translation helpful? Give feedback.
-
|
I bring the both of you here for clarification regarding BuddyPress Constants (BPC) as I endeavor to bring issue #4 (Site Health Info tab) closer to a final draft. The task at hand is to reconcile some of the differences between the 50 BPC that are listed in the latest BPC listing (see initial post ⬆️ ) and the 46 BPC that are listed in the Site Health Info tab - BPC panel (site.url/wp-admin/site-health.php?tab=debug) and since the delta is 4, the following represent the 4:
I believe the first 3 were intentionally omitted, speculation on my part, although they may prove in the future that the state of these may be useful. This just leaves Next up is the clarification of what should be considered "deprecated" whereby, of the 50 BPC there were 12 identified as such, e.g., based on the
As an example, this is how a deprecated BPC reads in the BPC panel (Site Health Info tab):
And, I'm a bit confused as to the criteria that was used to determine a deprecated status. This is another reason for having a Deprecation Policy that should remove the ambiguity of who, what, where, when, why & how (5 Ws & H) we make determination, along with a minimum period of time (or minimum number of major release cycles), when applicable, the loading of such. So the question is: are these 3 actually deprecated? |
Beta Was this translation helpful? Give feedback.
-
|
I think @imath is the best person to reply to those accurately. You could also read the comments from this pull request, buddypress/buddypress#232, where he mentions which constants should be deprecated. I'm pretty sure we don't have a Deprecation Policy and our process is a bit loose (which that doesn't mean it is a bad process but it can cause confusion and questions). |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the reply and reference to the PR, I found a conversation for As to the Deprecation Policy that is a "TODO" item that is earmarked by issue #290, which currently only has notes for deprecated functions. In reality, this policy should cover all items, e.g., Constants, Methods (Class), Classes, etc. |
Beta Was this translation helpful? Give feedback.
-
Note
At the moment, this is at a conceptual stage that will lead to a preliminary layout that will include a description of purpose for each constant and/or other relevant information.
When applicable, footnotes are included for a constant. A constant without a footnote means that it can be "user defined" (most likely within wp-config.php).
Currently, there are a total of 50 constants, of which:
https://github.com/buddypress/buddypress/blob/12.4.0/src/bp-members/bp-members-functions.php#L1875
(BP 14)
https://github.com/buddypress/buddypress/blob/master/src/bp-members/bp-members-functions.php#L1864
https://github.com/buddypress/buddypress/blob/12.4.0/src/bp-core/bp-core-functions.php#L518
(BP 14)
https://github.com/buddypress/buddypress/blob/master/src/bp-core/deprecated/14.0.php#L52
Footnotes
Footnotes
Deprecated, a "doing it wrong" error notice is cast. ↩ ↩2 ↩3 ↩4 ↩5 ↩6 ↩7 ↩8 ↩9 ↩10
To be deprecated in BP 14.0.0 (see Trac ticket 9104 & Trac ticket 6123) ↩ ↩2
Defined in BuddyPress plugin. ↩ ↩2
Conditionally defined, if not previously defined. ↩ ↩2 ↩3 ↩4 ↩5 ↩6 ↩7 ↩8 ↩9 ↩10 ↩11 ↩12 ↩13 ↩14 ↩15 ↩16 ↩17 ↩18 ↩19
Beta Was this translation helpful? Give feedback.
All reactions