Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hangs from loadCommands #91

Open
thewilloftheshadow opened this issue Sep 14, 2024 · 1 comment
Open

Fix hangs from loadCommands #91

thewilloftheshadow opened this issue Sep 14, 2024 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed p:nodejs The node.js package

Comments

@thewilloftheshadow
Copy link
Member

Currently, the nodeJS loadCommands handler only looks for the default export and tries to load it as a command, but if there is no default export, it will just hang forever and never resolve (with no error).

Need to find a way to either catch that there isn't a default or make it throw an error instead of hanging.

@thewilloftheshadow thewilloftheshadow added bug Something isn't working help wanted Extra attention is needed p:nodejs The node.js package labels Sep 14, 2024
@thewilloftheshadow
Copy link
Member Author

Another instance where it hangs is recursive imports (e.g. importing from index.js where loadCommands is called)

@thewilloftheshadow thewilloftheshadow changed the title Missing import hangs loadCommands Fix hangs from loadCommands Sep 14, 2024
@thewilloftheshadow thewilloftheshadow modified the milestone: v0.5.0 Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed p:nodejs The node.js package
Projects
None yet
Development

No branches or pull requests

1 participant