Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore pot status files that predate boot #278

Merged
merged 2 commits into from
Dec 16, 2023

Conversation

grembo
Copy link
Collaborator

@grembo grembo commented Nov 30, 2023

Simple check based on the system's uptime.

This makes sure pots running before the machine was rebooted
won't affect pot's state model.

@grembo grembo changed the title Ignore pot status files that pre-date boot Ignore pot status files that predate boot Nov 30, 2023
@grembo grembo force-pushed the ignore-outdated-status-files branch from 75b2e2b to fea6575 Compare November 30, 2023 15:36
@grembo grembo force-pushed the ignore-outdated-status-files branch from fea6575 to 295fad9 Compare November 30, 2023 15:51
@grembo grembo requested a review from pizzamig December 1, 2023 17:34
@grembo grembo requested a review from hny-gd December 13, 2023 11:03
@grembo
Copy link
Collaborator Author

grembo commented Dec 13, 2023

@bretton Could you take a look at that? (it works fine in production for us)

@bretton
Copy link

bretton commented Dec 13, 2023

@bretton Could you take a look at that? (it works fine in production for us)

using this playbook for sample environment with inventory.five/hosts configured with the following secret developer settings enabled, I am able to build an environment:

# developer
pot_update_from_github=1
pot_git_repo=https://github.com/bsdpot/pot.git
patch_pot=1
pull_request_id=278

I then rebooted all 5 hosts. All pots came up.

Copy link
Collaborator

@pizzamig pizzamig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grembo grembo merged commit 7a9e223 into bsdpot:master Dec 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants