Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pyinotify instead of busy-polling #2

Open
alexbepple opened this issue Nov 29, 2009 · 1 comment
Open

Use Pyinotify instead of busy-polling #2

alexbepple opened this issue Nov 29, 2009 · 1 comment

Comments

@alexbepple
Copy link

I think instead of busy-polling every second, the test daemon should listen to Pyinotify, http://trac.dbzteam.org/pyinotify. This is both more efficient and improves the response time to a change. When your tests take less than a second to run, an additional up-to-one-second delay is quite noticeable.

Of course, platform issues have to be considered here. As far as I can tell, the current walking algorithm is platform-independent. Therefore I would suggest to refactor the notification mechanism to a strategy pattern and use Inotify only on Linux.

@eugene-eeo
Copy link

Watchdog could be used as well, it provides system dependent notifiers which inevitably boost performance. Tdaemon could be a simple wrapler around it with some fancy notification features based on exit status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants