Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Mimetypes by type without subtype #33

Open
shiribailem opened this issue Sep 29, 2020 · 0 comments
Open

Suggestion: Mimetypes by type without subtype #33

shiribailem opened this issue Sep 29, 2020 · 0 comments

Comments

@shiribailem
Copy link
Contributor

It's been a while since I dug into this project (just haven't been following any podcasts these days), but with a recent update over mimetypes a thought popped in my mind.

I figured I'd add it here since I'm in no state to set up and test myself right now.

Perhaps use either a split("/") or str.startswith() to test the first half of the mimetype only.

As all mimetypes podfox works with are either audio or video types, this would save managing the subtypes in a list.

Possible code around line 195:

if hasattr(link, 'type') and (link.type.split("/")[0] in ("audio", "video")):

If nothing else, it's something I'm sure someone can bang their head against and come up with a solution to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant