-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated with the Android config #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a Fixture file for mobile devices and added a separate test script for mobile
Prettier implemented to fix indentation issues Removed unnecessary console logs Removed the unnecessary local branching
Updated with the right android version & device
Removed additional fixture files Created a new config file for Playwright local Removed mobile-test file Added code to the fixture file for patching mobile caps
add local log to ignore
Fixture consolidation
local log file ignore
Removed additional config file
Removed few capabilities Added latest Playwright version
updated Webkit on Ventura
fixed the REST api response issue
updated with the new mobile pattern
asambstack
approved these changes
Aug 4, 2023
browserstack.config.js
Outdated
const cdpUrl = `wss://cdp.browserstack.com/playwright?caps=${encodeURIComponent( | ||
JSON.stringify(caps) | ||
)}`; | ||
console.log(`--> ${cdpUrl}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this console.log
mobile-fixture.js
Outdated
const { test } = require("./browserstack.config"); | ||
|
||
// BrowserStack Specific Capabilities. | ||
// Set 'browserstack.local:true For Local testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// Set 'browserstack.local:true For Local testing | |
// Set "browserstack.local" as true in caps below to enable Local testing |
Review this with product
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a Fixture file for mobile devices and added a separate test script for mobile