Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated with the Android config #3

Merged
merged 13 commits into from
Aug 4, 2023

Conversation

somebodysmokein
Copy link
Contributor

Created a Fixture file for mobile devices and added a separate test script for mobile

somebodysmokein and others added 6 commits June 20, 2023 02:13
Created a Fixture file for mobile devices and added a separate test script for mobile
Prettier implemented to fix indentation issues
Removed unnecessary console logs
Removed the unnecessary local branching
Updated with the right android version & device
Removed additional fixture files
Created a new config file for Playwright local
Removed mobile-test file
Added code to the fixture file for patching mobile caps
add local log to ignore
@somebodysmokein somebodysmokein requested a review from a team as a code owner July 17, 2023 10:15
somebodysmokein and others added 7 commits July 17, 2023 15:50
local log file ignore
Removed additional config file
Removed few capabilities
Added latest Playwright version
updated Webkit on Ventura
fixed the REST api response issue
updated with the new mobile pattern
const cdpUrl = `wss://cdp.browserstack.com/playwright?caps=${encodeURIComponent(
JSON.stringify(caps)
)}`;
console.log(`--> ${cdpUrl}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this console.log

const { test } = require("./browserstack.config");

// BrowserStack Specific Capabilities.
// Set 'browserstack.local:true For Local testing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Set 'browserstack.local:true For Local testing
// Set "browserstack.local" as true in caps below to enable Local testing

Review this with product

@agrawalsaurabhs agrawalsaurabhs merged commit bd46315 into browserstack:main Aug 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants