Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.20.0 with BREAKING CHANGES - ternary expressions formatting updates coming again #493

Open
brodycj opened this issue Mar 8, 2021 · 2 comments

Comments

@brodycj
Copy link
Owner

brodycj commented Mar 8, 2021

Considering that the new --offset-ternary-expressions option did not really resolve the inconsistent nested ternary formatting issue in #41 and led to another issue in #468, and that a simpler solution in PR #492 seems to resolve the nested ternary formatting, I am thinking about renaming the option again.

I would like to request that people raise any objections ASAP as I would like to make the new release with the simpler solution in PR #492 in the near future.

@aMarCruz as I said in PR #492 this would likely undo some changes that you contributed in the past.

/cc @aMarCruz @sheerun


UPDATE 1 (June 2021): I would like to make some updates to resolve outdated dependencies as discussed in issue #587 before making these breaking changes.

Update 2 (June 2021): Now that the npm audit issues from issue #587 have been resolved, I would like to make this update (in prettierX release 0.19.0) before merging the updates from Prettier 2.3.1.

Please see the following for more information:

@brodycj brodycj pinned this issue Mar 8, 2021
@aMarCruz
Copy link
Contributor

@brodybits no problem with that.

@brodycj brodycj changed the title 0.18.0 release with BREAKING CHANGES again 0.19.0 release with BREAKING CHANGES again May 23, 2021
@brodycj brodycj changed the title 0.19.0 release with BREAKING CHANGES again BREAKING CHANGES - ternary expressions coming again Jun 15, 2021
@brodycj brodycj changed the title BREAKING CHANGES - ternary expressions coming again BREAKING CHANGES - ternary expressions formatting updates coming again Jun 23, 2021
@brodycj brodycj changed the title BREAKING CHANGES - ternary expressions formatting updates coming again v0.19.0 with BREAKING CHANGES - ternary expressions formatting updates coming again Jun 23, 2021
@brodycj
Copy link
Owner Author

brodycj commented Jun 23, 2021

FYI I am planning (again) to make these breaking changes in upcoming 0.19.0 release, before merging updates from Prettier 2.3.1.

update: These updates are again slated for upcoming prettierX release 0.20.0.

Please see the following for more information:

@brodycj brodycj changed the title v0.19.0 with BREAKING CHANGES - ternary expressions formatting updates coming again v0.20.0 with BREAKING CHANGES - ternary expressions formatting updates coming again Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants