Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to play 2.5 #28

Open
domdorn opened this issue Jun 21, 2016 · 4 comments
Open

upgrade to play 2.5 #28

domdorn opened this issue Jun 21, 2016 · 4 comments

Comments

@domdorn
Copy link

domdorn commented Jun 21, 2016

they've migrated to akka streams.. lib doesn't work anymore :/

@brikis98
Copy link
Owner

Yes, that's a bit unfortunate. I thought their plan had been to maintain backwards compatibility with Iteratee/Enumerator stuff until Play 3.x, but looks like that's not the case. I suspect it's a decent amount of work to do this upgrade and am not sure when I'll be able to get to it. PRs welcome :)

@rocketpages
Copy link

I'm very interested in this upgrade for a project I'm working on. Trying to prioritize against other things, but I may start chipping away at it.

@AbhinabKanrar
Copy link

As far I understand, ping-play is based on scala. The javaapi would internally call scala api while rendering streams. And, scala would depend on Play's own Future API for asynchronous programming.

Now Play 2.5 edition is focusing on Java 8 CompletionStage for asynchronous nature(for Java people). And I think Play would entirely move into CompletionStage way in next couple of build. In this case, what to do? Do we need to rebuild entire architecture? Or, some minor patches would do the things?

@brikis98
Copy link
Owner

@Abhinabyte Play 2.5 introduced Akka Streams as a replacement for Iteratees. That's what ping-play should use as well, both for Java and Scala APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants