Skip to content
This repository has been archived by the owner on Mar 29, 2024. It is now read-only.

Keep add button visible #153

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Katyadelarosa
Copy link

Seems like a good idea to have an option to keep the Add button always visible, because when you start typing it disappears until you go to the next line.

@codecov-io
Copy link

codecov-io commented Jan 17, 2019

Codecov Report

Merging #153 into master will increase coverage by 0.47%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   81.66%   82.13%   +0.47%     
==========================================
  Files          15       15              
  Lines         349      347       -2     
  Branches       50       49       -1     
==========================================
  Hits          285      285              
+ Misses         64       62       -2
Impacted Files Coverage Δ
src/model/index.js 58.44% <0%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87bad6...2c834a0. Read the comment docs.

@brijeshb42
Copy link
Owner

@Katyadelarosa What happens to the text that is already there in that block that has the (+) button?

@Katyadelarosa
Copy link
Author

@brijeshb42 Nothing, it doesn't affect existing content, but I just pushed a fix for the position of the (+) button, it was not updating when moving between blocks with content

@brijeshb42
Copy link
Owner

@Katyadelarosa Just got a chance to look at this and it seems like your PR changes the default behavior and makes the (+) button always be visible by default. Your changes should not change the default behavior and should only be applied when enabled through prop. Let me know if you can take a look. Otherwise, I can merge your PR and apply the required changes after that and then publish a new version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants