feat(cloudformation): enrich cloudformation cloudsplaining inspected key line #6590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxamel
changed the title
maxamel
changed the title
added 2 commits
July 23, 2024 18:29
…ewio/checkov into enrich_cloudsplaining_eval_keys
added 2 commits
July 24, 2024 07:46
…ewio/checkov into enrich_cloudsplaining_eval_keys
bo156
approved these changes
Jul 24, 2024
| @@ -42,7 +42,7 @@ jobs: | |||
| id: changed-files-specific | |||
| uses: tj-actions/changed-files@eaf854ef0c266753e1abec356dcf17d92695b251 # v44 | |||
| with: | |||
| files: tests/cloudformation/checks/resource/aws/**/* | |||
| files: tests/cloudformation/checks/resource/aws/example*/**/* | |||
There was a problem hiding this comment.
So it won't run cfn-lint of python files which exist in: tests/cloudformation/checks/resource/aws/
| if fnmatch.fnmatch(violating_action, action): # found the violating action in our list of actions | ||
| action_line = self.extract_action_line(statement.statement, action) | ||
| if action_line > 0: | ||
| self.inspected_key_line = action_line |
There was a problem hiding this comment.
so we have only one inspected_key_line in a resource?
There was a problem hiding this comment.
It will be one inspected key line per violation. This field gets copied to the record, which then gets put in the report.
lirshindalman
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds capability for cloudformation cloudsplaining to mark inspected_key_line for exposing of error lines.
Checklist: