feat(terraform): Ensure that only critical system pods run on system nodes #5665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdefise
had a problem deploying
to
scan-security
GitHub Actions
Failure
tdefise
had a problem deploying
to
scan-security
GitHub Actions
Failure
tdefise
had a problem deploying
to
scan-security
GitHub Actions
Failure
added 2 commits
November 2, 2023 13:53
tdefise
had a problem deploying
to
scan-security
GitHub Actions
Failure
lirshindalman
approved these changes
Nov 6, 2023
pull bot
pushed a commit
to Julian-Louis/checkov
that referenced
this pull request
Nov 6, 2023
…nodes (bridgecrewio#5665) * Created check CKV_AZURE_228 * Created check CKV_AZURE_229 * Those are from another PR * Should not be there * Removed unused import * Fixed flake8 findings * fixed bug in the test * adjust check ID --------- Co-authored-by: Thomas Defise <[email protected]> Co-authored-by: Anton Grübel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Fixes #5664
Description
Microsoft recommends isolating critical system pods from application pods to prevent misconfigured or rogue application pods from accidentally killing system pods.
This can be enforced by creating a dedicated system node pool with the CriticalAddonsOnly=true:NoSchedule taint to prevent application pods from being scheduled on system node pools.
This is explained here https://learn.microsoft.com/en-us/azure/aks/use-system-pools?tabs=azure-cli#system-and-user-node-pools
(Through Terraform, this is done with "only_critical_addons_enabled")
Fix
Set the "only_critical_addons_enabled" variable to true within the default_node_pool
Checklist: