Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform): Support for merge func inside jsondecode #5656

Merged
merged 2 commits into from
Oct 19, 2023
Merged

feat(terraform): Support for merge func inside jsondecode #5656

merged 2 commits into from
Oct 19, 2023

Conversation

ChanochShayner
Copy link
Contributor

@ChanochShayner ChanochShayner commented Oct 17, 2023 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Support merge func inside jsondecode + UT.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ChanochShayner ChanochShayner temporarily deployed to scan-security October 18, 2023 09:59 — with GitHub Actions Inactive
gruebel
gruebel approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@ChanochShayner ChanochShayner merged commit cc6aff5 into main Oct 19, 2023
30 checks passed
@ChanochShayner ChanochShayner deleted the support-merge-inside-jsondecode branch October 19, 2023 11:21
pull bot pushed a commit to tooniez/checkov that referenced this pull request Oct 19, 2023
@ChanochShayner @actions-user
feat(terraform): Support for merge func inside jsondecode (bridgecrew…
a6556f6 
…io#5656)

* Support merge inside jsondecode

* fix policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruebel gruebel gruebel approved these changes

@lirshindalman lirshindalman lirshindalman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChanochShayner @gruebel @lirshindalman