Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adding retry for urllib3.exceptions protocolError #5575

Merged
merged 6 commits into from
Sep 19, 2023
Merged

chore: Adding retry for urllib3.exceptions protocolError #5575

merged 6 commits into from
Sep 19, 2023

Conversation

ChanochShayner
Copy link
Contributor

@ChanochShayner ChanochShayner commented Sep 19, 2023 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Adding retry for urllib3.exceptions.protocolError by creating a new poolManager instance.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ChanochShayner
Merge branch 'main' into add-retry-for-urllib3-exceptions-protocolError
d64056a 
# Conflicts:
#	checkov/common/bridgecrew/integration_features/features/fixes_integration.py
@ChanochShayner ChanochShayner temporarily deployed to scan-security September 19, 2023 06:58 — with GitHub Actions Inactive
@ChanochShayner ChanochShayner temporarily deployed to scan-security September 19, 2023 07:55 — with GitHub Actions Inactive
@ChanochShayner ChanochShayner merged commit 43fee3d into main Sep 19, 2023
30 checks passed
@ChanochShayner ChanochShayner deleted the add-retry-for-urllib3-exceptions-protocolError branch September 19, 2023 08:11
lif2 pushed a commit to lif2/checkov that referenced this pull request Sep 19, 2023
@ChanochShayner @actions-user
chore: Adding retry for urllib3.exceptions protocolError (bridgecrewi…
74dc72b 
…o#5575)

* adding retry for urllib3.exceptions protocolError

* Mypy

* Mypy

* Mypy

* CR fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omryMen omryMen omryMen approved these changes

@bo156 bo156 bo156 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChanochShayner @omryMen @bo156