Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openapi): New OpenAPI check CKV_OPENAPI_20 #5253

Merged
merged 9 commits into from
Jul 4, 2023
Merged

Conversation

tsmithv11
Copy link
Collaborator

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

New check for exposed API keys

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel temporarily deployed to scan-security June 27, 2023 14:23 — with GitHub Actions Inactive
Copy link
Contributor

@JamesWoolfenden JamesWoolfenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gruebel gruebel temporarily deployed to scan-security July 3, 2023 18:52 — with GitHub Actions Inactive
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏖️

@gruebel gruebel merged commit 787abad into main Jul 4, 2023
32 checks passed
@gruebel gruebel deleted the openapi-checks-jun23 branch July 4, 2023 07:03
gruebel added a commit to gruebel/checkov that referenced this pull request Jul 5, 2023
* New OpenAPI check

* Fix flake

* Update ClearTextAPIKey.py

* Update ClearTextAPIKey.py

* fix mypy

* Fix mypy

* change folder name

* improve check logic

---------

Co-authored-by: James Woolfenden <[email protected]>
Co-authored-by: gruebel <[email protected]>
gruebel added a commit to gruebel/checkov that referenced this pull request Jul 5, 2023
* New OpenAPI check

* Fix flake

* Update ClearTextAPIKey.py

* Update ClearTextAPIKey.py

* fix mypy

* Fix mypy

* change folder name

* improve check logic

---------

Co-authored-by: James Woolfenden <[email protected]>
Co-authored-by: gruebel <[email protected]>
@dizer
Copy link

dizer commented Jul 5, 2023

Hey there! I'm curious about why these keys are considered more exposed compared to oauth2 keys. It would be great if you could provide some insight into the reasoning behind this change. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants