From fd23ab78a8d4a4da516f5cc6a4d66d0b68c9ae9c Mon Sep 17 00:00:00 2001 From: Mike Urbanski Date: Wed, 18 Oct 2023 16:01:54 -0500 Subject: [PATCH] do not get fixes for on prem integrations --- .../integration_features/features/fixes_integration.py | 1 + tests/common/integration_features/test_fixes_integration.py | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/checkov/common/bridgecrew/integration_features/features/fixes_integration.py b/checkov/common/bridgecrew/integration_features/features/fixes_integration.py index 4d033a7af40..bfa6b33625b 100644 --- a/checkov/common/bridgecrew/integration_features/features/fixes_integration.py +++ b/checkov/common/bridgecrew/integration_features/features/fixes_integration.py @@ -36,6 +36,7 @@ def is_valid(self) -> bool: return ( self.bc_integration.is_integration_configured() and not self.bc_integration.skip_fixes + and not self.bc_integration.on_prem and not self.integration_feature_failures ) diff --git a/tests/common/integration_features/test_fixes_integration.py b/tests/common/integration_features/test_fixes_integration.py index ddeec2ace38..9ac7958a595 100644 --- a/tests/common/integration_features/test_fixes_integration.py +++ b/tests/common/integration_features/test_fixes_integration.py @@ -21,11 +21,16 @@ def test_integration_valid(self): instance = BcPlatformIntegration() instance.skip_fixes = False instance.platform_integration_configured = True + instance.on_prem = False fixes_integration = FixesIntegration(instance) self.assertTrue(fixes_integration.is_valid()) + instance.on_prem = True + self.assertFalse(fixes_integration.is_valid()) + + instance.on_prem = False instance.skip_fixes = True self.assertFalse(fixes_integration.is_valid())