From d72d5af30d719da19e029e76bd3bcecd9e02f38e Mon Sep 17 00:00:00 2001 From: Max Amelchenko Date: Sun, 25 Aug 2024 12:13:29 +0300 Subject: [PATCH] remove list value sorting in TF and fix test --- checkov/terraform/modules/module_utils.py | 1 - .../checks/data/aws/test_CloudSplainingDataExfiltration.py | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/checkov/terraform/modules/module_utils.py b/checkov/terraform/modules/module_utils.py index 98165dd362d..7853124ff63 100644 --- a/checkov/terraform/modules/module_utils.py +++ b/checkov/terraform/modules/module_utils.py @@ -221,7 +221,6 @@ def clean_parser_types_lst(values: list[Any]) -> list[Any]: str_values_in_lst.append(val) else: result_values.append(val) - str_values_in_lst.sort() result_values.extend(str_values_in_lst) return result_values diff --git a/tests/terraform/checks/data/aws/test_CloudSplainingDataExfiltration.py b/tests/terraform/checks/data/aws/test_CloudSplainingDataExfiltration.py index e544a6501f1..0194d0119d1 100644 --- a/tests/terraform/checks/data/aws/test_CloudSplainingDataExfiltration.py +++ b/tests/terraform/checks/data/aws/test_CloudSplainingDataExfiltration.py @@ -33,12 +33,12 @@ def test(self): self.assertEqual(summary["skipped"], 0) self.assertEqual(summary["parsing_errors"], 0) + self.assertIn('statement/[0]/actions/[1]/', report.failed_checks[0].check_result.get('evaluated_keys')) self.assertIn('statement/[0]/actions/[2]/', report.failed_checks[0].check_result.get('evaluated_keys')) + self.assertIn('statement/[0]/actions/[3]/', report.failed_checks[0].check_result.get('evaluated_keys')) self.assertIn('statement/[0]/actions/[4]/', report.failed_checks[0].check_result.get('evaluated_keys')) self.assertIn('statement/[0]/actions/[5]/', report.failed_checks[0].check_result.get('evaluated_keys')) self.assertIn('statement/[0]/actions/[6]/', report.failed_checks[0].check_result.get('evaluated_keys')) - self.assertIn('statement/[0]/actions/[7]/', report.failed_checks[0].check_result.get('evaluated_keys')) - self.assertIn('statement/[0]/actions/[8]/', report.failed_checks[0].check_result.get('evaluated_keys')) self.assertEqual(passing_resources, passed_check_resources) self.assertEqual(failing_resources, failed_check_resources)