Slightly "un-golf" pair creation #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianeray
reviewed
Aug 16, 2024
| ) | ||
| }.joinToString("") | ||
|
|
||
| jar to combinedScope |
There was a problem hiding this comment.
I like this. I started in Groovy so Kotlin's x to y never comes immediately to mind. This is awesome.
Will try to get one of my colleagues here to double-check everything and get [one of these] merged. 🤞
|
Going to zap this PR since it's pointing at my fork and one of the others should become "the" PR, probably your inductiveautomation#53. You could reset it to the head of my inductiveautomation#56 and force push. Want to make sure you get the credit. |
|
The changes have been merged into inductiveautomation#53, I assume you'll do a squash merge into master.
I need things to do like I need a hole in my head 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this makes it easier to understand which part of the code is actually doing the de-duping.